fix(core.transform-kit): 检查缺少方法时先看旧类是否有实现 #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
典型的场景应该是androidx等库对新版本Android SDK新增API的依赖非常及时， 但这些依赖并不总是有用。在低版本Android SDK上编译时，新增API不存在对 这些库实际上没有影响。 我们检查替换类名时也应该先看看原先依赖的方法是否能找到。如果本来就找不到， 那我们的新类也没必要一定实现缺失的方法。 Tencent#1251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
典型的场景应该是androidx等库对新版本Android SDK新增API的依赖非常及时，
但这些依赖并不总是有用。在低版本Android SDK上编译时，新增API不存在对
这些库实际上没有影响。
我们检查替换类名时也应该先看看原先依赖的方法是否能找到。如果本来就找不到，
那我们的新类也没必要一定实现缺失的方法。
fix #1251